Added missing TR2 henchman death sound (ID 838) and appropiate TR2 -> TEN conversion.#1161
Added missing TR2 henchman death sound (ID 838) and appropiate TR2 -> TEN conversion.#1161Stranger1992 wants to merge 2 commits intodevelopfrom
Conversation
Stranger1992
added
easy
There was a problem hiding this comment.
Pull request overview
Restores the missing TR2 stick-goon death SFX by assigning TEN sound slot 838 to a new TR2 henchman death sample, and updates the TR2→TEN sound-slot conversion so TR2 SFX 73 maps correctly in TombEngine/TEN workflows.
Changes:
- Updated TEN sound catalog entry 838 to
TR2_Henchman_Death4and added the referenced.wavsample. - Updated TombEngine sound slot list and TR2 engine conversion mapping so TR2
ENEMY_DEATH1(id 73) maps to TEN 838. - Added a WadTool changelog entry for the change.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| TombLib/TombLib/Catalogs/TEN Sound Catalogs/TEN_ALL_SOUNDS.xml | Defines TEN sound slot 838 as the TR2 henchman death sound and attaches the sample. |
| TombLib/TombLib/Catalogs/Engines/TombEngine/Sounds.xml | Renames sound slot 838 from an empty TR3 placeholder to a TR2 death sound label. |
| TombLib/TombLib/Catalogs/Engines/TR2/Sounds.xml | Remaps TR2 sound id 73 (ENEMY_DEATH1) to TEN slot 838 for TR2→TEN conversion. |
| Installer/Changes.txt | Documents the WadTool change in the installer changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * Added "Preview flyby sequence" and "Preview camera" context menus for cameras. | ||
|
|
||
| WadTool: | ||
| * Added missing TR2 henchman death sound (ID 838) and appropiate TR2 -> TEN conversion. |
There was a problem hiding this comment.
Typo in changelog entry: "appropiate" should be "appropriate".
| * Added missing TR2 henchman death sound (ID 838) and appropiate TR2 -> TEN conversion. | |
| * Added missing TR2 henchman death sound (ID 838) and appropriate TR2 -> TEN conversion. |
| <sound id="836" name="TR3_CLEANER_LOOP" ten="836" /> | ||
| <sound id="837" name="TR3_CRICKET_LOOP" ten="837" /> | ||
| <sound id="838" name="TR3_EMPTY1" ten="838" /> | ||
| <sound id="838" name="TR2_ENEMY_DEATH4" ten="838" /> |
There was a problem hiding this comment.
In TombEngine sound names, TR2 sounds in this catalog use the TR2_HENCHMAN_* naming (e.g., TR2_HENCHMAN_DEATH1/2/3). This new entry uses TR2_ENEMY_DEATH4, which is inconsistent with the existing naming scheme and with the underlying TEN sound name (TR2_Henchman_Death4). Consider renaming this to TR2_HENCHMAN_DEATH4 for consistency and easier lookup.
| <sound id="838" name="TR2_ENEMY_DEATH4" ten="838" /> | |
| <sound id="838" name="TR2_HENCHMAN_DEATH4" ten="838" /> |
SFX
73 ENEMY_DEATH1in TR2 corresponded to the stick-goon's death sound. This is missing in TombEngine.This PR restores it and fixes the TR2->TEN conversion
You can find the SFX file HERE